Rule Definition
Compatible with CISQ 33 and especially ASCRM-CWE-252-data
Remediation
Replace all the default JavaScript implementation JSON.parse and JSON.stringify with angular.fromJson or angular.toJson instead.
Violation Code Sample
function CarCtrl($scope, $http) {
$scope.getAllCars = function () {
$scope.url = 'getAllCars';
$http.get($scope.url).success(function (data, status) {
var carsFromServer = JSON.parse(data);
$scope.cars = carsFromServer.allCars;
}).error(function (data, status) {
$scope.response = 'Request failed';
});
}
$scope.getAllCars();
}
Fixed Code Sample
function CarCtrl($scope, $http) {
$scope.getAllCars = function () {
$scope.url = 'getAllCars';
$http.get($scope.url).success(function (data, status) {
var carsFromServer = angular.fromJSON(data);
$scope.cars = carsFromServer.allCars;
}).error(function (data, status) {
$scope.response = 'Request failed';
});
}
$scope.getAllCars();
}
Related Technologies
Technical Criterion
Architecture - Reuse
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.