CRITICAL
Rule Definition
The software constructs all or part of a dynamic evaluation using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended code when it is sent to a downstream component.
This could allow attackers to access or execute unexpected, dangerous commands directly on the operating system.
Remediation
Assume all input is malicious.
Avoid using inputs. If it is not possible, use an "accept known good" input validation strategy, i.e., use stringent white-lists that limit the character set based on the expected value of the parameter in the request. This will indirectly limit the scope of an attack.
Violation Code Sample
String ctl = request.getParameter("ctl");
Class cmdClass = Class.forName(ctl + "Command");
Worker ao = (Worker) cmdClass.newInstance();
ao.doAction(request);
Fixed Code Sample
String ctl = request.getParameter("ctl");
// Compute String command without user-input control
Class cmdClass = Class.forName(ctl + command);
Worker ao = (Worker) cmdClass.newInstance();
ao.doAction(request);
Reference
CWE-470: Use of Externally-Controlled Input to Select Classes or Code ('Unsafe Reflection')
https://cwe.mitre.org/data/definitions/470.html
Open Web Application Security Project (OWASP)
https://www.owasp.org/index.php/Top_10_2007
CISQ: ASCSM-CWE-470
Related Technologies
Technical Criterion
CWE-88 - Improper Neutralization of Argument Delimiters in a Command ('Argument Injection')
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.