Rule Definition
Don't Terminate Loops with Method Calls:
The overhead is significant. Not only the call of method comes with a important cost but depending on the complexity and the performance of the called method the impact on performance can be huge. In deed, the method can be called several hundred to several thousand times.
Remediation
Use a local variable to store the condition.
Violation Code Sample
for (int i=0; i < tab.length(); i++) { // VIOLATION
tab[i] = i;
}
Fixed Code Sample
int length = tab.length();
for (int i=0; i < length; i++) { // FIXED
tab[i] = i;
}
Reference
Java Reference:
http://www.precisejava.com/javaperf/j2se/Loops.htm
Java Performance Tuning
By Jack Shirazi - Publisher : O'Reilly
ISBN 0-596-00377-3
or http://www.devx.com/tips/Tip/5625
C# Reference:
http://aspalliance.com/818
Related Technologies
Visual Basic
.Net
C++
JEE
FLEX
Technical Criterion
CWE-1050 - Excessive Platform Resource Consumption within a Loop
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.