CRITICAL
Rule Definition
The software constructs all or part of a dynamic evaluation using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended code when it is sent to a downstream component.
This could allow attackers to execute unexpected, dangerous commands directly on the operating system. This weakness can lead to a vulnerability in environments in which the attacker does not have direct access to the operating system, such as in web applications.
Remediation
Assume all input is malicious.
Avoid using inputs. If it is not possible, use an "accept known good" input validation strategy, i.e., use stringent white-lists that limit the character set based on the expected value of the parameter in the request. This will indirectly limit the scope of an attack.
Violation Code Sample
String js; // value given by an API request
...
ScriptEngine engine = manager.getEngineByName("javascript");
try {
Object res = engine.eval(js);
...
Fixed Code Sample
String js; // constant value
...
ScriptEngine engine = manager.getEngineByName("javascript");
try {
Object res = engine.eval(js);
...
Reference
CWE-94: Improper Control of Generation of Code ('Code Injection')
https://cwe.mitre.org/data/definitions/94.html
CWE-95: Improper Neutralization of Directives in Dynamically Evaluated Code ('Eval Injection')
https://cwe.mitre.org/data/definitions/95.html
Open Web Application Security Project (OWASP)
https://www.owasp.org/index.php/Top_10-2017_A1-Injection
CISQ: ASCSM-CWE-078
Related Technologies
Technical Criterion
CWE-88 - Improper Neutralization of Argument Delimiters in a Command ('Argument Injection')
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.