Rule Definition
Instead of the default window object, you should prefer the AngularJS wrapper service $window.
Violation Code Sample
var myApp = angular.module('myApp', []);
myApp.controller("myController", function ($scope) {
$scope.DisplayAlert = function (message) {
window.alert(message);
}
$scope.DisplayPrompt = function () {
var name = window.prompt('Enter Your Name');
window.alert('Hello ' + name);
}
});
Fixed Code Sample
var myApp = angular.module('myApp', []);
myApp.controller("myController", function ($scope, $window) {
$scope.DisplayAlert = function (message) {
$window.alert(message);
}
$scope.DisplayPrompt = function () {
var name = $window.prompt('Enter Your Name');
$window.alert('Hello ' + name);
}
});
Related Technologies
Technical Criterion
Programming Practices - Structuredness
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.